Skip to content

Eleino/feature/606 implement google analytics and perform minor uicontent fixes #608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
eleino wants to merge 42 commits into from
Closed

Eleino/feature/606 implement google analytics and perform minor uicontent fixes #608

eleino wants to merge 42 commits into from

Conversation

@eleino
Copy link
Contributor

@eleino eleino commented Dec 15, 2025

📄 Pull Request Overview

Closes #606

🔧 Changes Made

  1. Added Google Analytics to the site through nextjs/third-parties/google
  2. Added env variables for GA id with conditional checking for dev/prod environment
  3. Verified that the analytics was working with a member of the prod team
  4. Fixed the issue with single news page image becoming really tiny on mobile screen widths
  5. Updated the links to Action Plan and Activity Report on PRG page

✅ Checklist Before Submission

  • Functionality: I have tested my code, and it works as expected.
  • JSDoc: I have added or updated JSDoc comments for all relevant code.
  • Debugging: No console.log() or other debugging statements are left.
  • Clean Code: Removed commented-out or unnecessary code.
  • Tests: Added new tests or updated existing ones for the changes made.
  • Documentation: Documentation has been updated (if applicable).

📝 Additional Information

Provide any additional context or information that reviewers may need to know:

  • Screenshots:
kuva
  • Dependencies: [Mention any new dependencies or breaking changes]
  • Known Issues: [List any known issues or limitations]

bhi049 and others added 30 commits November 12, 2025 12:24
@bhi049
Images exported and testing card layout
347be3f
@bhi049
Testing new card design on clan page
e3b01ec
@bhi049
Use ModularCard in ClanAllSubPage
76fe8a6
@bhi049
Fixing desktop clan card, mobile started
ed35ac9
@bhi049
Mobilecard added and adjustments to modular card.
172e90c
@bhi049
Mobilecard improved
372318d
@bhi049
Responsive update to clancards
8dbf50c
@bhi049
tweaks to scrolling behavior
465af96
@bhi049
prev/next page buttons and logic removed, new searchbar implementatio…
c80d8de 
…n started
@bhi049
use LayoutWithSidebars, move PageTitle to ClanAllSubPage
f7cfa99
@bhi049
responsivenes updates and new searchbar
4632345
@bhi049
testing better content fitment and responsivenes for desktop clancard
7320344
@bhi049
Mobile clancard updated
b2e0cf9
@bhi049
Mobilecard layout updated
f4cee6b
@bhi049
change page title to Clans/Klaanit
5039bae
@bhi049
remove global styles and improve responsiveness
d5ab41f
@bhi049
mobilecarditemwrap, fix mistake
6243313
@bhi049
small tweaks to modularcard
ff38695
@bhi049
fix modularcard sm breakpoint and mobilecard improvements
2eb1228
@bhi049
cleanup ClanAllSubPage
73c5af7
@bhi049
simular search logic as other pages and more cleanup
d583aca
@bhi049
cleanup
02d84a6
@bhi049
SearchBarTablet fix
02c9e80
@bhi049
change modularcardtheme name to CLANCARD
7828c45
@bhi049
fix mobilecard gap and padding + eslint fix
8ff691c
@eleino
Removed image placeholder from news without one, and added a static t…
46b7d30 
…itle to single news page
@eleino
Removed an empty div with no class definition in the style file
525b7a9
@bhi049
testing clanLabel implementation
7bf668f
@bhi049
ellipsis for lable text
4d87c5d
@eleino
Changed news text to align to left, decreased the width of the text a…
adcd13f 
…rea, and slightly increased line height of the text
bhi049 and others added 12 commits November 25, 2025 14:10
@bhi049
Reduce clan label padding/gap and enable flex-wrap
951980f
@bhi049
move clan label icon map to entities
e5a3df9
@bhi049
small font fix
a975f3f
@eleino
Increased news text width slightly on smaller screens
9d34d55
@bhi049
Fix mobile ClanCard hover overflow and lock layout heights
58c50a7
@Rutjake
Merge branch 'dev' into nikolas/enhancement/564-update-clan-page
98f96b5
@Rutjake
Merge pull request #597 from Alt-Org/nikolas/enhancement/564-update-c…
537127a 
…lan-page

Nikolas/enhancement/564 update clan page
@Rutjake
fix(seo): Restore Open Graph and metadata logic lost in merge
87905b1 
Restores lost SEO codes related to conflicting merges or accidental deletions on GitHub, specifically:
- **Restores** enhanced news and gallery page rendering logic.
- **Improves/Restores** SEO metadata handling (titles, descriptions, keywords).
- **Refactors** Open Graph image retrieval and URL formatting for better social sharing.
@Skoivumaki
Merge pull request #601 from Alt-Org/eleino/enhancement/596-update-ne…
8c8b583 
…ws-card-and-single-newspage-rendering-logic

Eleino/enhancement/596 update news card and single newspage rendering logic
@eleino
Added Google Analytics via @next/third-parties
e70f01b
@eleino
Modified news element image to stop it shrinking indefinitely
c269526
@eleino
Updated Google drive links on PRG page
e1f314c
@eleino eleino linked an issue Dec 15, 2025 that may be closed by this pull request
Implement Google Analytics and Perform Minor UI/Content Fixes #606
Open
@eleino eleino closed this Dec 15, 2025
@eleino eleino removed a link to an issue Dec 15, 2025
Implement Google Analytics and Perform Minor UI/Content Fixes #606
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leolabdev leolabdev Awaiting requested review from leolabdev leolabdev is a code owner

@Skoivumaki Skoivumaki Awaiting requested review from Skoivumaki Skoivumaki is a code owner

@kaisahakola kaisahakola Awaiting requested review from kaisahakola kaisahakola is a code owner

@Rutjake Rutjake Awaiting requested review from Rutjake Rutjake is a code owner

@patinen patinen Awaiting requested review from patinen patinen is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@eleino @bhi049 @Rutjake @Skoivumaki