Updated AvatarEditor #1165
Open
Updated AvatarEditor #1165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Hardcoded to hair atm
attached script to HorizontalScrollView-Grid instead of BottomMenu
- Added VerticalScrollViewGrid for category selection - renamed ScrollBarContentLoader script to ScrollBarFeatureLoader
- Also removed placeholder images from verticalscroll
VerticalScrollView-Grid => CategoryGrid HorizontalScrollView-Grid => FeatureGrid
- Clicking features on FeatureGrid now updates the character - Made SetFeature function from FeaturePicker public to bypass old logic - Feature slot that's being changed hardcoded to hair for now - Made BookImage transparent in editor to see more easily
- Now changing the category works - Feature category Id:s being hardcoded is not optimal, returning to it later
- Added LayoutElement component to prefab - Replaced many CategoryGrid components - Added UpdateCellSize function Category selection now shows 3 categories regardless of screen size/aspect ratio. It does not update when changing screen size while the app is running for now.
Not sure if OnEndDrag is the right event yet
- It now clicks the button on the cell after clamping - Clicking the cells still works too, planning on changing this later
- Now there are cells now both top and bottom when loading the grid items
- Renamed wrongly named variable - Made CategoryGrid create 3 of each category for future purposes
- Renamed completely unused scripts, keeping them if I need to look at the code in the future
- It still gives an error about it when opening AvatarEditor, but these changes did not cause it
- Moved FeaturePicker functionality that was still needed to Featuresetter and moved old avatareditorcontroller functionality to new one
- Moved Buttons and changed graphic for the save button
not localised yet
- Made DefaultButton and RevertButton update the highlighted piece on featureselection
-Text not localized
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced the current page/book style categorization with a sideways scrolling bar
Replaced category selection with a vertical scroll that shows 3 items at a time
Added color selection visually
Added a speech bubble that shows a random phrase listed in the GDD when opening AvatarEditor
Added a confirmation popup window for saving
Left old scripts in the files if needed for reference in the near future
Known Issues