Skip to content

Conversation

@maolinml
Copy link
Collaborator

@maolinml maolinml commented Sep 13, 2024

Issue #, if available:
This PR (https://github.com/Altanali/amazon-braket-sdk-python/pull/4/files) is not complete for AHS where measurement noise is not included. Besides, LocalSimulator("braket_ahs") is used for the emulation, which is similar to LocalSimulator("braket_sv"), instead of LocalSimulator("braket_dm"), for the gate based device. To be consistent, we propose to use LocalSimulator("braket_ahs_noisy") for AHS developed in this branch https://github.com/amazon-braket/amazon-braket-default-simulator-python/tree/mao/ahs_noise/src/braket/analog_hamiltonian_simulator/rydberg.

Description of changes:

  1. LocalSimulator("braket_ahs_noisy") is used for emulation which automatically takes care all the noises including SPAM noise.
  2. Because of the previous change, the method "run_passes" is modified accordingly such that when apply_noise_model is set to False, the method won't modify the program.

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have checked that my tests are not configured for a specific region or account (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants