Skip to content

Conversation

@Juanpe
Copy link

@Juanpe Juanpe commented Jul 14, 2015

Hi,

First time congratulations by this repository. Very usefully and very clean.

I'm using this audio player in my app and I've needed some changes and I thought that this changes could be new features for this player.

I've added a new method that load an play a streaming audio file. I've changed current method "loadItem" and I execute in background with blocks, so don't block the UI.

Also, I've added a new player property, the state. Now player has got various states, buffering, playing, stopped, paused and error. With this change the user be able to know the current status of player.

I've changed the delegate notification. Now, the method called "_notifyStatusChanged" is executed when set the current status of player.

Wait you feedback about this changes.

Thanks for code again,
Juanpe

Add Audio Streaming
@Krivoblotsky
Copy link
Contributor

Thank you! I'll check it out asap.

@Juanpe
Copy link
Author

Juanpe commented Aug 26, 2015

Hi Serg Krivoblotsky,
Could you check my code?
Thanks

@Krivoblotsky
Copy link
Contributor

Hi, Juanpe. Thank you for the PR. I'm having some difficulties with permissions over this repository. Once I will be able to merge pull requests, I'll check your code once again and merge it.
Thanks for contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants