-
Notifications
You must be signed in to change notification settings - Fork 5
Added functionality similar to parquet-tools to print info of parquet… #65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Added functionality similar to parquet-tools to print info of parquet… #65
Conversation
…enient-introspection-of-parquet-files
|
Testing: |
|
remote file |
|
xieandrew
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested the commands and everything seems to work. Just a few comments.
| Option... options) | ||
| throws IOException { | ||
|
|
||
| Lazy<software.amazon.awssdk.services.s3.S3Client> s3ClientLazy = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could be imported
| } | ||
|
|
||
| public static void run(InputFile inputFile, boolean json, Option... options) throws IOException { | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Empty line here could be removed
| System.setOut(new PrintStream(outContent)); | ||
|
|
||
| try { | ||
| InMemoryCatalog catalog = new InMemoryCatalog(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
InMemoryCatalog implements Closeable, should this be in a try with resources statement combined with the previous line?
… files.