json casing on created in requestresponse

[simen-rekkedal]

Description

Related Issue(s)

• #{issue number}

Verification

• Your code builds clean without any errors or warnings
• Manual testing done (required)
• Relevant automated test added (if you find this hard, leave it and we'll help out)
• All tests run green

Documentation

• User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

Summary by CodeRabbit

• Chores
  • Standardized JSON field naming for system response data to improve API consistency.
  • Responses now include a populated "created" timestamp where applicable, exposing creation time in returned data.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

📝 Walkthrough

Walkthrough

Adds JSON serialization attribute [JsonPropertyName("created")] to Created properties in two system response models and populates those Created fields in several response mappings within the request system user service.

Changes

Cohort / File(s)	Summary
Model: JSON property attribute src/Core/Models/SystemUsers/AgentRequestSystemResponse.cs, src/Core/Models/SystemUsers/RequestSystemResponse.cs	Added [JsonPropertyName("created")] attribute to the public Created property in both classes to set the JSON field name to "created"
Service: populate Created in mappings src/Authentication/Services/RequestSystemUserService.cs	Populates the Created field on response objects in multiple mapping methods (e.g., GetRequestByExternalRef, GetRequestByGuid, GetRequestByPartyAndRequestId, GetAgentRequestByGuid, GetAgentRequestByPartyAndRequestId)

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'json casing on created in requestresponse' directly describes the main change: adding JsonPropertyName attributes to specify JSON field casing for the Created property across system response models.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch test_of_support_case

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 0

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

src/Authentication/Services/RequestSystemUserService.cs (1)

416-428: Missing Created field in GetAgentRequestByGuid response mapping.

This method constructs a new AgentRequestSystemResponse but omits the Created field, whereas GetAgentRequestByPartyAndRequestId (line 513) and CheckUserAuthorizationAndGetAgentRequest (line 884) both include it. This inconsistency will result in different API responses depending on which endpoint is called.

Proposed fix

         return new AgentRequestSystemResponse()
         {
             Id = res.Id,
             IntegrationTitle = res.IntegrationTitle,
             ExternalRef = res.ExternalRef,
             SystemId = res.SystemId,
             PartyOrgNo = res.PartyOrgNo,
             AccessPackages = res.AccessPackages,
             Status = res.Status,
+            Created = res.Created,
             RedirectUrl = res.RedirectUrl,
             TimedOut = res.TimedOut
         };

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud