Skip to content

deps: update interface#924

Merged
HauklandJ merged 2 commits intomainfrom
deps/update-interface
Feb 10, 2026
Merged

deps: update interface#924
HauklandJ merged 2 commits intomainfrom
deps/update-interface

Conversation

@HauklandJ
Copy link
Contributor

@HauklandJ HauklandJ commented Feb 10, 2026

Description

Related Issue(s)

  • #{issue number}

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

Summary by CodeRabbit

  • Dependencies

    • Updated Altinn.Platform.Storage.Interface package to version 4.4.0.
  • Breaking Changes

    • Modified InstanceOwner model: Email property removed and replaced with Username and ExternalIdentifier properties.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 10, 2026

📝 Walkthrough

Walkthrough

Updates Altinn.Platform.Storage.Interface NuGet package from version 4.3.0 to 4.4.0. Modifies test data and test assertions to reflect InstanceOwner API changes, replacing the Email property with Username and ExternalIdentifier properties.

Changes

Cohort / File(s) Summary
Dependency Update
src/Storage/Altinn.Platform.Storage.csproj
NuGet package reference updated from Altinn.Platform.Storage.Interface 4.3.0 to 4.4.0.
Test Data
test/UnitTest/TestData/TestData.cs
InstanceOwner initialization in Instance_1_Email changed from setting Email to setting Username ("epost:test.user@example.com") and ExternalIdentifier ("urn:altinn:person:idporten-email:test.user@example.com").
Test Assertions
test/UnitTest/TestingRepositories/InstanceTests.cs
Test expectations for Instance_Create_WithEmail_Ok updated to assert Username and ExternalIdentifier properties instead of Email property; Email assertion removed.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'deps: update interface' is vague and overly broad. While it references the main change (updating a dependency), it does not specify which interface or what the significance of the update is. Revise the title to be more specific about the nature of the update, such as 'deps: update Altinn.Platform.Storage.Interface to 4.4.0' or include relevant details about the API changes introduced.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch deps/update-interface

No actionable comments were generated in the recent review. 🎉

🧹 Recent nitpick comments
test/UnitTest/TestData/TestData.cs (1)

340-358: Clarify the "(legacy type)" comment.

Line 340 labels Instance_1_Username as "legacy type", yet Username is the new property introduced in v4.4.0 (replacing Email). If this instance represents a pre-existing username-based login (not email-based), the comment is fine—but it could confuse future readers into thinking the Username property is deprecated. Consider rewording to make the distinction clearer, e.g., "Instance with direct username self identification (non-email)".


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Konrad-Simso Konrad-Simso self-assigned this Feb 10, 2026
@HauklandJ HauklandJ moved this to 🔎 In review in Team Altinn Studio Feb 10, 2026
@sonarqubecloud
Copy link

@HauklandJ HauklandJ merged commit 32a3fd0 into main Feb 10, 2026
13 checks passed
@HauklandJ HauklandJ deleted the deps/update-interface branch February 10, 2026 11:34
@github-project-automation github-project-automation bot moved this from 🔎 In review to ✅ Done in Team Altinn Studio Feb 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

2 participants