Skip to content

added prop expandedByDefault to groups for sidenavigation #4006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
walldenfilippa wants to merge 1 commit into
base: feat/16446-navigation-validation
Choose a base branch
from
Open

added prop expandedByDefault to groups for sidenavigation #4006

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/codegen/Common.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -800,6 +800,12 @@ const common = {
.optional({ default: false })
.setDescription('Whether this group should mark pages as completed when the user finishes'),
),
new CG.prop(
'expandedByDefault',
new CG.bool()
.optional({ default: false })
.setDescription('Whether the sidebar group should be expanded by default'),
),
),
IPagesSettingsWithGroups: () =>
new CG.obj(
Expand Down
7 changes: 5 additions & 2 deletions src/features/navigation/components/PageGroup.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,8 +132,11 @@ function PageGroupMultiple({
const buttonId = `navigation-button-${group.id}`;
const listId = `navigation-page-list-${group.id}`;

const [isOpen, setIsOpen] = useState(containsCurrentPage);
useLayoutEffect(() => setIsOpen(containsCurrentPage), [containsCurrentPage]);
const [isOpen, setIsOpen] = useState(containsCurrentPage || !!group.expandedByDefault);
useLayoutEffect(
() => setIsOpen(containsCurrentPage || !!group.expandedByDefault),
[containsCurrentPage, group.expandedByDefault],
);

const pageGroupHasErrors = validations !== ContextNotProvided && validations.hasErrors.group;
const pageGroupIsComplete = validations !== ContextNotProvided && validations.isCompleted.group;
Expand Down
Loading