Open
Conversation
Contributor
|
Hey! Thanks for contributing. Unfortunately we can't merge this right now as this would incurr a breaking change. There are apps that depend on this name and casing. Once we start work on the next major version we can probably include this |
danielskovli
requested changes
Aug 22, 2025
Contributor
danielskovli
left a comment
danielskovli
left a comment
There was a problem hiding this comment.
Thanks for your contributions. As was already mentioned, this is a breaking change and cannot be merged at the time being. But if the comments I've added are addressed, we can incorporate this into the v9 release.
Contributor
There was a problem hiding this comment.
This file should be renamed to match the class name.
| [FromRoute] string org, | ||
| [FromRoute] string app, | ||
| [FromBody] InstansiationInstance instansiationInstance, | ||
| [FromBody] InstantiationInstance InstantiationInstance, |
Contributor
There was a problem hiding this comment.
Parameters and other local variables should be camelCased.
danielskovli
changed the title
danielskovli
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issue(s)
InstansiationInstance#1434Verification
Documentation