Ability to switch between top and bottom.#38
Open
sanchin wants to merge 2 commits intoAndreiD:masterfrom
Open
Conversation
Owner
|
Thanks for doing this. I'll review it and push it when I find little time |
Owner
|
please see #68 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was looking for a way to display the Snackbar either on top or at the bottom of the screen and switching between this and the original design.Snackbar is tedious. If you feel like integrating this into the project, I'd be glad. This will effectively make it TBSnackbar or BTSnackbar ;)
Also - I don't know if the custom duration (in ms) was available in the original at the time you created this - the
@Durationannotation is restricted to one of the 3 values, so I've copied the IntRange annotation from the original one to support custom durations.If you'd only like the duration fix - I can make it a separate pull request.