-
Notifications
You must be signed in to change notification settings - Fork 23
fix: stable #146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix: stable #146
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR configures deployment scripts and infrastructure for the "stable" blockchain network. The changes primarily update deployment scripts, configuration files, and remove deprecated test files, while improving the verification fallback mechanism in the deployment helper scripts.
Key changes:
- Adds support for the "stable" network in Foundry configuration
- Updates deployment scripts to target stable network with specific token addresses
- Improves shell script verification logic to fallback to global ETHERSCAN_API_KEY
- Removes deprecated Hardhat test files and unused configuration files
Reviewed changes
Copilot reviewed 8 out of 10 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
test/deprecated/hardhat/tokenWrappers/pufferPointTokenWrapper.test.ts |
Removed deprecated Hardhat test file (248 lines) |
slither.config.json |
Removed Slither static analysis configuration file |
scripts/deployPullTokenWrapper.s.sol |
Updated to deploy PullTokenWrapperAllow on stable network with atomic initialization and implementation verification |
scripts/DistributionCreator.s.sol |
Updated scripts to target stable network with new token addresses and fee configurations |
helpers/foundryMultiChainScript.sh |
Enhanced verification logic with fallback to global ETHERSCAN_API_KEY for etherscan verifier |
funding.json |
Removed Optimism Retro funding configuration file |
foundry.toml |
Added stable network configuration and consolidated Etherscan API keys to use generic ETHERSCAN_API_KEY |
logo.svg |
Removed repository logo SVG file |
README.md |
Removed CodeCov coverage badge reference |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| amounts[0] = 0.1 ether; // 1 token with 18 decimals | ||
| amounts[1] = 0.1 ether; // 1 token with 18 decimals |
Copilot
AI
Dec 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inconsistent comment: The comment says "// 1 token with 18 decimals" but the value is 0.1 ether which equals 0.1 tokens, not 1 token. Either update the comment to "// 0.1 token with 18 decimals" or change the value to 1 ether.
| amounts[0] = 0.1 ether; // 1 token with 18 decimals | |
| amounts[1] = 0.1 ether; // 1 token with 18 decimals | |
| amounts[0] = 0.1 ether; // 0.1 token with 18 decimals | |
| amounts[1] = 0.1 ether; // 0.1 token with 18 decimals |
scripts/deployPullTokenWrapper.s.sol
Outdated
|
|
||
| // Need to choose the implementation type and if implementation needs to be deployed | ||
|
|
||
| address implementation = address(new PullTokenWrapperAllow()); |
Copilot
AI
Dec 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trailing whitespace detected at the end of the line. This should be removed for code cleanliness.
| address implementation = address(new PullTokenWrapperAllow()); | |
| address implementation = address(new PullTokenWrapperAllow()); |
| monad = {chaindId = 143, key = "${ETHERSCAN_API_KEY}", url = "${VERIFIER_URL_143}" } | ||
| stable = {chaindId = 988, key = "${ETHERSCAN_API_KEY}", url = "${VERIFIER_URL_988}" } |
Copilot
AI
Dec 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo in key name: chaindId should be chainId. This will prevent Foundry from correctly identifying the chain ID for the monad and stable networks.
| monad = {chaindId = 143, key = "${ETHERSCAN_API_KEY}", url = "${VERIFIER_URL_143}" } | |
| stable = {chaindId = 988, key = "${ETHERSCAN_API_KEY}", url = "${VERIFIER_URL_988}" } | |
| monad = {chainId = 143, key = "${ETHERSCAN_API_KEY}", url = "${VERIFIER_URL_143}" } | |
| stable = {chainId = 988, key = "${ETHERSCAN_API_KEY}", url = "${VERIFIER_URL_988}" } |
No description provided.