[4.1.1] fix compile on recent clang versions #382
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heifner
approved these changes
Jul 31, 2025
linh2931
approved these changes
Jul 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On recent clang versions (certainly clang20 which I used for making this fix, but possibly 18 or 19 too, and certainly modern Xcodes as reported from community), cdt fails to compile due to something wonky in the ancient version of jsoncons where it is referring to an
empty_here that just doesn't exist 🤷♀️ I mean look..cdt/tools/jsoncons/include/jsoncons/json_type_traits.hpp
Lines 175 to 177 in d658c90
no
empty_there. I think the code is just buggy and newer versions of clang stumble on it.I didn't even venture to try and update the library.
Considering it for stable because it has been reported in community.