Apl 2024 replace jcommander with pico cli #1162
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuriy-ln
approved these changes
Aug 5, 2021
alzinchenko
approved these changes
Aug 5, 2021
apl-exec/src/main/java/com/apollocurrency/aplwallet/apl/exec/CmdLineArgs.java
Outdated
Show resolved
Hide resolved
apl-exec/src/main/java/com/apollocurrency/aplwallet/apl/exec/CmdLineArgs.java
Outdated
Show resolved
Hide resolved
apl-exec/src/main/java/com/apollocurrency/aplwallet/apl/exec/Apollo.java
Show resolved
Hide resolved
AndrewBoyarsky
requested changes
Feb 11, 2022
Collaborator
There was a problem hiding this comment.
Add unit tests for cmd line args:
https://picocli.info/#_testing_your_application
We need to ensure that core options: --no-shard-import, --no-shard-create, -s, -d 3, -n 1 and others work fine with pico-cli
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.