-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Update to xunit v3 #2440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to xunit v3 #2440
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 143 out of 158 changed files in this pull request and generated no comments.
Files not reviewed (15)
- Directory.Packages.props: Language not supported
- eng/Test.targets: Language not supported
- src/Snippets/Snippets.csproj: Language not supported
- test/Polly.Core.Tests/CircuitBreaker/Controller/CircuitStateControllerTests.cs: Evaluated as low risk
- test/Polly.Core.Tests/CircuitBreaker/BrokenCircuitExceptionTests.cs: Evaluated as low risk
- test/Polly.Core.Tests/CircuitBreaker/IsolatedCircuitExceptionTests.cs: Evaluated as low risk
- test/Polly.Core.Tests/Fallback/FallbackHandlerTests.cs: Evaluated as low risk
- test/Polly.Core.Tests/CircuitBreaker/CircuitBreakerResiliencePipelineBuilderTests.cs: Evaluated as low risk
- test/Polly.Core.Tests/CircuitBreaker/CircuitBreakerOptionsTests.cs: Evaluated as low risk
- test/Polly.Core.Tests/CircuitBreaker/CircuitBreakerResilienceStrategyTests.cs: Evaluated as low risk
- test/Polly.Core.Tests/Fallback/FallbackResiliencePipelineBuilderExtensionsTests.cs: Evaluated as low risk
- test/Polly.Core.Tests/CircuitBreaker/CircuitBreakerStateProviderTests.cs: Evaluated as low risk
- src/Snippets/Docs/Testing.cs: Evaluated as low risk
- build.cake: Evaluated as low risk
- test/Polly.Core.Tests/CircuitBreaker/CircuitBreakerPredicateArgumentsTests.cs: Evaluated as low risk
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2440 +/- ##
=======================================
Coverage 96.15% 96.15%
=======================================
Files 309 309
Lines 7128 7128
Branches 1005 1005
=======================================
Hits 6854 6854
Misses 221 221
Partials 53 53
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
0d89f44 to
43001fd
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
43001fd to
d4bf38c
Compare
Cherry-pick changes from #2440 to prepare to switch to xunit v3.
Cherry-pick changes from #2440 to prepare to switch to xunit v3.
Update to xunit v3. Resolves #2439.
38f4de9 to
e28f271
Compare
Directory.Packages.props
Outdated
| <PackageVersion Include="System.ValueTuple" Version="4.5.0" /> | ||
| <PackageVersion Include="xunit" Version="2.9.3" /> | ||
| <PackageVersion Include="xunit.runner.visualstudio" Version="3.1.4" /> | ||
| <PackageVersion Include="xunit.v3" Version="3.0.1" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider using xunit.v3.mtp-v2 instead. Latest version is 3.2.1.
Directory.Packages.props
Outdated
| <PackageVersion Include="System.Threading.Tasks.Extensions" Version="4.5.4" /> | ||
| <PackageVersion Include="System.ValueTuple" Version="4.5.0" /> | ||
| <PackageVersion Include="xunit" Version="2.9.3" /> | ||
| <PackageVersion Include="xunit.runner.visualstudio" Version="3.1.4" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This shouldn't be needed if you intend to also run with MTP.
Use `xunit.v3.mtp-v2` instead of `xunit.v3`.
Remove now-redundant reference to xunit.runner.visualstudio.
Remove redundant package reference.
Switch to using FsCheck.Xunit.v3.
GitHubActionsTestLogger isn't strong-named which means MTP can't compile due to the strong-name requirement, so disable it.
|
Styker tests are still broken both without MTP (stryker-mutator/stryker-net#3117) and with MTP (stryker-mutator/stryker-net#3094). Unit tests only work with MTP disabled, otherwise the fact GitHubActionsTestLogger isn't strong-named becomes a problem and causes test compilation to fail. |
|
I'm going to close this out as it's otherwise about to reach its first birthday. We can revisit in the future if/when stryker supports MTP. |
Resolves #2439.