Convert to qt5 by adjusting namespaces #6
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mp15
force-pushed
the
qt5_conversion
branch
from
3352837 to
fea0685
Compare
QPushButton now part of QtWidgets not QtGui
QVBoxLayout QGridLayout QPushButton QLineEdit QSpinBox all moved from QtGui to QtWidgets in Qt5
QDialogButtonBox moved from QtGui to QtWidgets in Qt5.
Auto gen fixes
The QtWidgets.QFileDialog.getOpenFileName function returns 2 values. Only the first is required, the second argument being present generates an error. Fix required for Linux, untested if required on win32 systems.
…-box-fixes Fixes to dialog window returned file paths
QGraphicsView is now within QtWidgets instead of QtGui in Qt5.
Fixes to make App file compatible with Qt5
References to qApp needs to be updated to QtWidgets.QApplication for Qt5 compatibility.
Fixes to App file for Qt5 compatibility.
Updated Qt4 reference to Qt5.
Fixing a typo and capitalisation issue within the Statistics panel
Contributor
|
Thanks Martin, Really appreciate your work. I will try to update the code as early as possible with more functions added using QT5 and invite you to contribute if you'd like to do this. Cheers, |
Fixes to statistics panel text
Updating references to PySide to PySide2.
Further Qt5 conversion work.
Author
|
Closed in favour of #11 as @DanielFaulkner has been working on this more recently and his code includes my changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given that it is hard to get a working QT4 on the current version of OS X, I have made the first steps towards converting the code so that it works under QT5.