bugfix: updateSelectInput handle correctly named list as choices#464
Merged
TymekAppsilon merged 5 commits intoAppsilon:developfrom Dec 2, 2025
Merged
bugfix: updateSelectInput handle correctly named list as choices#464TymekAppsilon merged 5 commits intoAppsilon:developfrom
TymekAppsilon merged 5 commits intoAppsilon:developfrom
Conversation
Correct a bug where value is not correctly attributed to the data-value attribute in semantic selectInput when using named list as choices.
Contributor
|
Hi, thank you for your contribution! Two questions:
|
Contributor
Author
|
Here you'll find a reproducible example. |
TymekAppsilon
approved these changes
Dec 2, 2025
Contributor
TymekAppsilon
left a comment
There was a problem hiding this comment.
Looks good to me! Sorry, for the hold up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correct a bug where value is not correctly attributed to the data-value attribute in semantic selectInput when using named list as choices.
Have you read the Contributing Guidelines?
Description
Fix a bug when you use named list as choices list. jsonlite::toJSON badly handle the choices list when it came to R named list. Shiny expect a simple JS array. To do that we just have to unname & unlist the initial choices list to get a value vector.
Definition of Done
R CMD check, linter, unit tests, spelling)..Rdfiles withroxygen2::roxygenise())