Skip to content

Allow root password to be updated using arcadedb.server.rootPassword and arcadedb.server.rootPasswordPath #2059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ExtReMLapin wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Allow root password to be updated using arcadedb.server.rootPassword and arcadedb.server.rootPasswordPath #2059

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b92084b
Allow root password to be updated using ENV variable
Mar 12, 2025
bdd4a37
removed extra root existance check
Mar 12, 2025
e742d90
Also allow rootPasswordPath to overwrite the root password
Mar 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 33 additions & 0 deletions server/src/main/java/com/arcadedb/server/security/ServerSecurity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,8 +125,41 @@
}
}

final String rootPasswordFromEnv = server != null ?
server.getConfiguration().getValueAsString(GlobalConfiguration.SERVER_ROOT_PASSWORD) :
GlobalConfiguration.SERVER_ROOT_PASSWORD.getValueAsString();



final String rootPasswordPath = server != null ?
server.getConfiguration().getValueAsString(GlobalConfiguration.SERVER_ROOT_PASSWORD_PATH) :
GlobalConfiguration.SERVER_ROOT_PASSWORD_PATH.getValueAsString();


final String rootPasswordFromFile = rootPasswordPath != null ? (Files.isReadable(Path.of(rootPasswordPath)) ? Files.readString(Path.of(rootPasswordPath)) : null) : null;

if (users.isEmpty() || (users.containsKey("root") && users.get("root").getPassword() == null))
{
askForRootPassword();
}
else if ((rootPasswordFromFile != null || rootPasswordFromEnv != null) && (users.containsKey("root")))
{
final String curRootPassword = users.get("root").getPassword();
if (rootPasswordFromFile != null && rootPasswordFromEnv != null)
LogManager.instance().log(this, Level.WARNING, "Both `arcadedb.server.rootPassword` and `arcadedb.server.rootPasswordPath` settings were used, falling back to `arcadedb.server.rootPasswordPath`");

final String pickedNewRootPassword = rootPasswordFromFile == null ? rootPasswordFromEnv : rootPasswordFromFile;


if (curRootPassword != pickedNewRootPassword)

Check warning on line 154 in server/src/main/java/com/arcadedb/server/security/ServerSecurity.java

View check run for this annotation

Codacy Production / Codacy Static Code Analysis

server/src/main/java/com/arcadedb/server/security/ServerSecurity.java#L154 

Use equals() to compare object references.

Check warning on line 154 in server/src/main/java/com/arcadedb/server/security/ServerSecurity.java

View check run for this annotation

Codacy Production / Codacy Static Code Analysis

server/src/main/java/com/arcadedb/server/security/ServerSecurity.java#L154 

Use equals() to compare strings instead of '==' or '!='
{
credentialsValidator.validateCredentials("root", pickedNewRootPassword);
final String encodedPassword = encodePassword(pickedNewRootPassword, ServerSecurity.generateRandomSalt());
getUser("root").setPassword(encodedPassword);
saveUsers();
}
}


final long fileLastModified = usersRepository.getFileLastModified();
if (fileLastModified > -1 && reloadConfigurationTimer == null) {
Expand Down
Loading