Skip to content
This repository was archived by the owner on Nov 17, 2020. It is now read-only.

Updated TempFly hook to TempFly 3.0 compliance.#67

Open
ChiefMoneyBags wants to merge 1 commit intoArcanePlugins:masterfrom
ChiefMoneyBags:master
Open

Updated TempFly hook to TempFly 3.0 compliance.#67
ChiefMoneyBags wants to merge 1 commit intoArcanePlugins:masterfrom
ChiefMoneyBags:master

Conversation

@ChiefMoneyBags
Copy link

Fixes the incompatibility issue with TempFly using its new requirement provider api. TempFly 3.0 will be released on spigot within the next few days.

log(LogLevel.INFO, "&8[&71/5&8] &7Checking compatibility...");
checkCompatibility();
if (Bukkit.getPluginManager().getPlugin("TempFly") != null) {
try {tempflyRequirement = new TempFlyRequirement();} catch (Exception e) {}
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I put this in a try block as it will error with old TempFly versions that do not contain requirement provider. I didn't factor in their support as it was bugged anyway. You can add a message here in console to update TempFly to latest version for support.

public void exitCombat(Player p) {
TempFly.getAPI().getUser(p).submitFlightResult(new ResultAllow(this, RequirementProvider.InquiryType.OUT_OF_SCOPE, V.requirePassCombat));
}

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can control the fall damage and chat messages in the ResultDeny and ResultAllow constructors if you want.

@lokka30
Copy link
Member

lokka30 commented Aug 19, 2020

Thank you very much @ChiefMoneyBags for submitting the PR and giving PoeticRainbow a fixed version - highly appreciated!

I am currently working on a complete overhaul to this plugin, so all of the old code currently sitting in this repo has been scrapped.
Would I be able to post an update to PhantomCombat's spigot resource page with the file you posted here? - no worries at all if you don't want me to do that.

Have a great day :)

@ChiefMoneyBags
Copy link
Author

Thanks for your response. The code in that phantom combat fix isn't compatible with the version of TempFly currently on spigot, i gave PoeticRainbow a beta jar to use with the fix. I am hoping to release my update soon. I will let you know when i'm ready for that to be posted, perhaps i can get it out tomorrow if i have enough time.

@ChiefMoneyBags
Copy link
Author

You can go ahead and post a resource update with the version i linked.

@lokka30
Copy link
Member

lokka30 commented Aug 22, 2020

Too good!

@lokka30
Copy link
Member

lokka30 commented Aug 23, 2020

I'll reopen this since I will need to implement this into the current code. ;)

@lokka30 lokka30 reopened this Aug 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants