-
Notifications
You must be signed in to change notification settings - Fork 0
fix(Challenge): Remove @Lob annotations from Challenge entity fields #84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Removed @lob annotations from blurb, promptMd, and expectedAnswer fields.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request simplifies the database mapping configuration for the Challenge entity by removing redundant @Lob annotations from TEXT fields that already have explicit column definitions. The @Lob annotations on blurb, promptMd, and expectedAnswer fields are removed since these fields already specify columnDefinition = "TEXT", making the @lob annotation unnecessary for PostgreSQL.
Changes:
- Removed
@Lobannotations from three Challenge entity fields while retaining their explicit TEXT column definitions - Simplified JPA mapping configuration by eliminating redundant annotations
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Removed @lob annotation from the code field in Submission class.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This pull request makes minor adjustments to how large text fields are mapped in the entity classes. Specifically, it removes the unnecessary
@Lobannotation from several fields that are already mapped to database columns with theTEXTtype.@Lobannotation from theblurb,promptMd, andexpectedAnswerfields in theChallengeentity, since these fields are already mapped asTEXTcolumns. [1] [2]@Lobannotation from thecodefield in theSubmissionentity, as it is also already mapped for large text storage.