search-in-workspace: allow search to follow symlinks #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
packages/search-in-workspace/src/browser/search-in-workspace-preferences.ts
Outdated
Show resolved
Hide resolved
packages/search-in-workspace/src/browser/search-in-workspace-widget.tsx
Outdated
Show resolved
Hide resolved
packages/search-in-workspace/src/browser/search-in-workspace-widget.tsx
Outdated
Show resolved
Hide resolved
| exclude?: string[]; | ||
| /** | ||
| * Whether symlinks should be followed while searching. | ||
| * See the vscode setting `"search.followSymlinks"`. |
Collaborator
There was a problem hiding this comment.
We probably do not need to reference the vscode setting here, I think it's self-explanatory.
Comment on lines
134
to
136
| if (options?.followSymlinks) { | ||
| args.add('--follow'); | ||
| } |
Collaborator
There was a problem hiding this comment.
I believe the option should be moved up.
Archie27376
force-pushed
the
gh10390_1
branch
2 times, most recently
from
b0b22eb to
c364de7
Compare
Archie27376
force-pushed
the
gh10390_1
branch
from
c364de7 to
55cabce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
How to test
Review checklist
Reminder for reviewers