Update to redis-rb 3.1.0; replace #unknown_items transaction with a script #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I want this for weighted upload targets because script support in redis-rb ~> 3.0 is much improved over the 2.x series. However, some changes were required. The changes reflected in this commit: 1. Redis::Client#sismember returns true or false, not 1 or 0. 2. Redis::Client#sadd with a single item returns true or false, not 1 or 0. (Redis::Client#add with multiple items returns the number of items added.) 3. Redis::Client#hgetall now returns a Hash. 4. Redis::Client#zrange with with_scores set to true now returns an Array of Arrays, not a single Array with interleaved items and scores. 5. Redis::Client#eval now counts keys and argv length; there is no longer a need to explicitly specify the number of keys. Finally, I replaced Tracker#unknown_items with a script because I didn't want to mess about with the previous pipeline.
Member
Author
|
It looks like the Cucumber scenarios are failing. They've been failing for a while, but I'll see if I can get them back up. |
Member
|
If you didn't see it yet, I fixed the scenarios. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR gets the tracker on redis-rb 3.1.0 (i.e. latest stable release), and updates all Redis code to match. Updating to the latest release made implementing the changes for #20 much easier. These changes make the tracker spec pass using redis-rb 3.1.0.
This PR also replaces the
multiblock inTransactions#unknown_itemswith a script, because that was one transaction I thought would be clearer as a script. AFAICT, the script has exactly the same effect and offers the same atomicity guarantees.