Skip to content

Improve ArduCAM_Touch read() and constructor safety #598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Chris0xdeadbeef wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Improve ArduCAM_Touch read() and constructor safety #598

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
74f950d
fix(ArduCAM_Touch.cpp): use uint8_t loop index and prevent division b…
Chris0xdeadbeef Sep 25, 2025
8ea1471
refactor(ArduCAM_Touch.cpp): removing space
Chris0xdeadbeef Sep 25, 2025
61fe1ca
fix(ArduCAM_Touch.cpp): use member initializer for prec in constructor
Chris0xdeadbeef Sep 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions ArduCAM_Touch/ArduCAM_Touch.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,11 +43,11 @@ UTFT TP_TFT(LCD_CS);



ArduCAM_Touch::ArduCAM_Touch(byte tcs,byte irq)
ArduCAM_Touch::ArduCAM_Touch(byte tcs,byte irq) : prec(10)
{
T_IRQ = irq;
T_CS = tcs;
SPI.begin();
T_IRQ = irq;
T_CS = tcs;
SPI.begin();
}

void ArduCAM_Touch::InitTouch(byte orientation)
Expand Down Expand Up @@ -81,7 +81,7 @@ void ArduCAM_Touch::read()

digitalWrite(T_CS,LOW);

for (int i=0; i<prec; i++)
for (uint8_t i=0; i<prec; ++i)
{
touch_WriteData(0x90);
ty+=touch_ReadData();
Expand All @@ -93,9 +93,10 @@ void ArduCAM_Touch::read()

digitalWrite(T_CS,HIGH);

TP_X=tx/prec;
TP_Y=ty/prec;

if (prec > 0) {
TP_X = tx / prec;
TP_Y = ty / prec;
}
}

bool ArduCAM_Touch::dataAvailable()
Expand Down