Skip to content

Fix: Handle rate limit exceptions with proper HTTP 429 response #208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
imDarshanGK wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −0
Open

Fix: Handle rate limit exceptions with proper HTTP 429 response #208

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions web/app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@
import metadata_manager
import build_manager
from builder import Builder
from utils.ratelimiter import RateLimitExceededException

# run at lower priority
os.nice(20)
Expand Down Expand Up @@ -220,6 +221,9 @@ def generate():
app.logger.info('Redirecting to /viewlog')
return redirect('/viewlog/'+build_id)

except RateLimitExceededException as ex:
app.logger.warning(f"Rate limit exceeded for client: {request.remote_addr}")
return render_template('error.html', ex=ex), 429
except Exception as ex:
app.logger.error(ex)
return render_template('error.html', ex=ex)
Expand Down