Web: Fix CAN options visibility for non-CAN boards #209
+203
−37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shiv-tyagi
requested changes
Jan 18, 2026
| f"Redis connection established with {redis_host}:{redis_port}" | ||
| ) | ||
| self.__boards_key_prefix = "boards-" | ||
| # bump version to invalidate stale board metadata in cache |
Member
There was a problem hiding this comment.
Please remove this change. We can handle the upgrade by manually clearing the cache.
|
|
||
| def __get_boards_at_commit_from_repo(self, remote: str, | ||
| commit_ref: str) -> tuple[list, list]: | ||
| commit_ref: str) -> tuple[list[dict], list[dict]]: |
Member
There was a problem hiding this comment.
Needs to be documented in the comment.
| try: | ||
| non_periph_boards, periph_boards = boards | ||
| needs_upgrade = False | ||
| if non_periph_boards and isinstance(non_periph_boards[0], str): |
Member
There was a problem hiding this comment.
Let's remove this as well. No need to worry about the upgrade due to cached stuff. We can clear it manually.
| vehicle_id=vehicle, | ||
| ) | ||
| if board not in boards_at_commit: | ||
| board_names_at_commit = [b["name"] for b in boards_at_commit] |
Member
There was a problem hiding this comment.
Better define a class for board with id, name and attributes, in the attributed put the has_can thing.
Author
There was a problem hiding this comment.
Defined a BoardMetadata class for above listed
Author
|
Hey @shiv-tyagi thanks for reviewing, I have addressed all the requested changes could you re-review it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes Issue #151 where the "CAN" feature category remained visible even when selecting a board that does not support CAN.
The Fix:
fillBuildOptionsin JS to re-render the category list whenever the board selection changes.has_can: false.includedirectives inhwdef.dat.Test Plan:
Closes #151