SIM_XPlane: Check if a docker container is being used.#32218
Open
KevinShek wants to merge 1 commit intoArduPilot:masterfrom
Open
SIM_XPlane: Check if a docker container is being used.#32218KevinShek wants to merge 1 commit intoArduPilot:masterfrom
KevinShek wants to merge 1 commit intoArduPilot:masterfrom
Conversation
KevinShek
force-pushed
the
docker_container_check_for_xplane
branch
3 times, most recently
from
a5f9ac5 to
c2a295d
Compare
…ot based on the IP from the listening port. Added a check for docker container so that connection was not based on the IP from the listening port due to docker uses a gateway IP address. added in the missing ;
KevinShek
force-pushed
the
docker_container_check_for_xplane
branch
from
c2a295d to
f2217a7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to address the following issue #20471 (comment). A docker container with ArduPilot is able to receive data packet from X-Plane 11 but unable to send commands to X-Plane 11.
A check was added to see if a docker container is being used and if it is then it does not execute the following function
last_recv_address. This is due to how docker sends data packet coming from Windows to the docker container and assigned it a different IP address than the actual Windows IP Address.Changes:
Reproducing the issue:
Running the following commands within a docker container with ArduPilot with a port open to "49001:49001/udp" for X-Plane.
Fixes:
Running the following command allows the user to use the IP address they want to send data too.
Additional possible issue:
The following warning appears in the terminal when connected to X-Plane, but X-Plane was able to receive commands from SITL:
"Warning, time moved backwards. Restarting timer."