fix: Docker network creation failure when CARDINAL_NAMESPACE is empty #254
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Fixes Sentry issue #7010783498: Docker network creation fails with 'invalid name: name is empty' when
CARDINAL_NAMESPACEis not set in the config.Root Cause:
client.go:122, theStart()method readscfg.DockerEnv["CARDINAL_NAMESPACE"]and passes it directly tocreateNetworkIfNotExists()CARDINAL_NAMESPACEis empty/unset, this results in an empty string being passed to Docker's NetworkCreate APIbuild.goandservice.godoesn't help because it runs AFTER the network creation attempt in different code pathsSolution
Added a check in
client.goStart()andPurge()methods to set a default namespace ("defaultnamespace") if empty, matching the behavior in:commands/cardinal/build.go:73-75common/docker/service/service.go:68-72This ensures consistency across all Docker operations and prevents the empty network name error.
Testing
CARDINAL_NAMESPACEsetworld cardinal startcommandRelated to parent session: https://app.cased.com/agents/35FhUgNSJoBCbdFF67ejXwUMVIW
Generated by Cased Agent