Skip to content

Conversation

@RogerHYang
Copy link
Contributor

tables

  • traces
  • spans

anticorrelator and others added 30 commits April 21, 2025 15:34
* Drop unique constraint migration

* Update /span_annotations REST route

* Update bulk inserters

* Update data loader to aggregate label fractions per span first

* Use correct kwarg name

* Use sqlite compatible migration

* Always use batch_alter_table

* Ensure that spans with an annotation aggregate labels properly

* Use auto recreate

* Re-apply SpanFilter

* Add migration to integration test

* Update OpenAPI schema

* Update traces router

* Update helper test

* Cast to floats before doing arithmetic

* Add type annotations

* Rebuild js client

* Use more robust typing

* Use a weighted avg for scores
- optimize query to not use cartesian product
- will scale very poorly as the number of labels increases

* Use properly per-span aggregated scores

* Cast to float before returning LabelFraction

* Add tests

* Remove score column from base stmt

* Use column indexing

* Improve clarity for type checker

* Fix unit test type checks
Co-authored-by: Alexander Song <axiomofjoy@gmail.com>
* feat(annotations): Annotation Config UI

* Fix style merging in AnnotationLabel

* Handle large values

* Rename card

* Persist annotation config via gql

* Convert annotation config popover to dialog

* Implement annotation selection toolbar + deletion

* Remove bad lint rule

* Replace dialog extra buttons with cancel button

* styling changes

* clean up annotation label

* Remove hover state from annotation label unless clickable
Co-authored-by: Mikyo King <mikyo@arize.com>
* temporary

* feat(annotations): add a ui to add / remove project annotations
* feat(annotations): addd notes UI to the side-bar

* cleanup

* add date

* add ci

* add changes
Additionally:

* Add react-aria package and FocusScope

* Use dark mode in storybook if OS is set to dark mode
chore: codegen on ts client

fix(annotations): fix facilitator

chore: fix text

chore: openapi and mypy fixes

chore: ruff

codegen
* feat(annotations): full annotations table

* feat(annotations): full annotation table in the feedback tab
* feat(admin): display retention policies

* memo
* rudimentary dialogue

* create the basic layout

* add validation

* Add forced refetch

* switch to paginated for now

* add mode
* feat(admin): project retention policies

* WIP

* final

* final

* cleanup

* cleanup

* cleanup

* cleanup
* Create annotation configs feature branch

* Add upsert logic to span annotation insertion

* Change trace annotation mutation as well

* Use SupportedSQLDialect enum

* Use default constraint names

* Use `create_index` for the partial constraint

* Implement backwards-compatible identifier index

* Add CODE to allowed annotator kind

* Start reorganizing migration to primarily use batch ops

* Reorganize downgrade to use batch ops

* Fix drop constraint call args

* Update constraint name

* Improve SpanAnnotation upsert logic

* Update trace annotation mutations

* Update REST route as well

* Fix constraint name in migration

* Refactor migrations

* Fix rest route

* Update test fixtures

* Add backwards compatible constraint to document annotations

* Add tests

* Add backwards compatibility test

* Remove needless fixture

* Ignore type issues on the return types

* Restructure mutation

* dedent

* decode ids outside transaction

* decode trace rowids outside session

---------

Co-authored-by: Alexander Song <axiomofjoy@gmail.com>
axiomofjoy and others added 20 commits April 21, 2025 15:34
* Add a per-user identifier to app annotations

* Add comment

* Satisfy type checker

* Add unique identifier to trace annotation mutation

* Fix

* Update test
…7248)

Co-authored-by: Tony Powell <apowell@arize.com>
Co-authored-by: Dustin Ngo <dustin@arize.com>
* Create span comment mutation

* Use correct id

* Comment -> Note

* Update gql schema
* Reserve span notes

* Update src/phoenix/server/api/routers/v1/spans.py

Co-authored-by: Anthony Powell <apowell@arize.com>

* Fix line length

---------

Co-authored-by: Anthony Powell <apowell@arize.com>
* Add span notes resolver

* Update gql schema

* Ruff 🐶
@github-project-automation github-project-automation bot moved this to 📘 Todo in phoenix Apr 28, 2025
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Apr 28, 2025
@RogerHYang RogerHYang marked this pull request as draft April 28, 2025 17:26
@github-project-automation github-project-automation bot moved this from 📘 Todo to 👍 Approved in phoenix Apr 28, 2025
@mikeldking mikeldking force-pushed the feat/annotations branch 2 times, most recently from 88e3b3c to e9ead03 Compare May 2, 2025 21:58
@mikeldking
Copy link
Collaborator

Probably need to do more tables: experiment runs, dataset examples etc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L This PR changes 100-499 lines, ignoring generated files.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

6 participants