feat: allow to pass custom readContract function #88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balthazar
changed the title
ppedziwiatr
reviewed
Jul 2, 2021
| ) { | ||
| const returningSrc = normalizeContractSource(contractSrc); | ||
| const swGlobal = new SmartWeaveGlobal(arweave, { id: contractId, owner: contractOwner }); | ||
| const swGlobal = new SmartWeaveGlobal(arweave, { id: contractId, owner: contractOwner, customReadContract }); |
Contributor
There was a problem hiding this comment.
from my understanding - after this change different "readContract" functions might be used inside SWC code and from the SDK itself (SDK always uses built-in readContract version). Not sure if that's a good solution - shouldn't this be consistent - ie. both SDK and version exposed within SWC must the same?
Author
There was a problem hiding this comment.
We already have our own custom readContract (we do not use the SDK one), we have to use that one during contract execution.
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Permits us to have more control over the kind of potentially heavy asynchronous work done during contract state computation.
Also minor comment change on something that seems to have been forgotten.