Add VariableValueHelper and improve variable value handling #2786
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arufonsu
approved these changes
Dec 27, 2025
WeylonSantana
force-pushed
the
fix-server-set-api
branch
from
9b3c167 to
1b4a262
Compare
WeylonSantana
force-pushed
the
fix-server-set-api
branch
2 times, most recently
from
18ed387 to
725a1b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #2785
I've been testing the API these past few days in the Naziozeno game, which is updated with the latest version of Intersect and has no changes in the API files. I found inconsistencies in setting variable values, mostly because the variable's DataType is ignored. So I'm strengthening the variable setting routes a bit more by adding a helper to consider the type of the value coming from the body in relation to the datatype of the variable whose value you want to change. This way, you no longer need to send all values as strings to the API.
In this case, the API will now consider the variable's type and return error messages if the value coming from the body is not of the same type or not be converted to the expected type