Do not ignore PytestRemovedIn8Warning.#420
Conversation
The main point of treating warnings as errors in the tests is to detect deprecation warningns early, so we have time to fix them before they become errors. We should only ignore deprecation warnings in very specific cases where we have ensured that doing so is save and will not cause problems. At the very least, every ignored deprecation warning should come with an issue that describes what is required to fix the problem.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #420 +/- ##
=======================================
Coverage 74.83% 74.83%
=======================================
Files 56 56
Lines 7824 7824
=======================================
Hits 5855 5855
Misses 1969 1969 ☔ View full report in Codecov by Sentry. |
teutoburg
left a comment
There was a problem hiding this comment.
Let's see what happens then...
|
I'll let the notebook test here finish to see whether that causes any warnings. I had never seen that |
|
FWIW, |
Can't remember. There must have been a good reason once, but that could very well be outdated... |
The main point of treating warnings as errors in the tests is to detect deprecation warningns early, so we have time to fix them before they become errors.
We should only ignore deprecation warnings in very specific cases where we have ensured that doing so is save and will not cause problems.
At the very least, every ignored deprecation warning should come with an issue that describes what is required to fix the problem.