Extend Blackbody wavelength range to cover all filters#872
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #872 +/- ##
==========================================
- Coverage 74.88% 74.83% -0.06%
==========================================
Files 69 69
Lines 8870 8868 -2
==========================================
- Hits 6642 6636 -6
- Misses 2228 2232 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
teutoburg
approved these changes
Feb 1, 2026
Contributor
teutoburg
left a comment
There was a problem hiding this comment.
See individual comment. Otherwise good 👍
Why not just remove the old code instead of commenting it out? But whatever...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The wavelength range for the WCU black-body source now extends from
!SIM.spectral.wave_mintowave_max. These values are set in the irdb mode yaml and should encompass all filters available in the mode.Closes #871