Skip to content

Extend Blackbody wavelength range to cover all filters#872

Merged
oczoske merged 2 commits intomainfrom
oc/fix_wcu_source
Feb 2, 2026
Merged

Extend Blackbody wavelength range to cover all filters#872
oczoske merged 2 commits intomainfrom
oc/fix_wcu_source

Conversation

@oczoske
Copy link
Collaborator

@oczoske oczoske commented Jan 30, 2026

The wavelength range for the WCU black-body source now extends from !SIM.spectral.wave_min to wave_max. These values are set in the irdb mode yaml and should encompass all filters available in the mode.

Closes #871

@oczoske oczoske self-assigned this Jan 30, 2026
@oczoske oczoske added the bugfix PR resolving one or more bugs (use "Bug" type for issues, not this label) label Jan 30, 2026
@oczoske oczoske added the METIS AIT Issues relating to METIS AIT simulations label Jan 30, 2026
@oczoske oczoske requested a review from teutoburg January 30, 2026 21:32
@codecov
Copy link

codecov bot commented Jan 30, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.83%. Comparing base (1c88878) to head (43d6249).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #872      +/-   ##
==========================================
- Coverage   74.88%   74.83%   -0.06%     
==========================================
  Files          69       69              
  Lines        8870     8868       -2     
==========================================
- Hits         6642     6636       -6     
- Misses       2228     2232       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@teutoburg teutoburg moved this to 👀 Awaiting Review in ScopeSim-development Feb 1, 2026
Copy link
Contributor

@teutoburg teutoburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See individual comment. Otherwise good 👍

Why not just remove the old code instead of commenting it out? But whatever...

@oczoske oczoske merged commit 023ef30 into main Feb 2, 2026
37 checks passed
@oczoske oczoske deleted the oc/fix_wcu_source branch February 2, 2026 10:12
@github-project-automation github-project-automation bot moved this from 👀 Awaiting Review to ✅ Done in ScopeSim-development Feb 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix PR resolving one or more bugs (use "Bug" type for issues, not this label) METIS AIT Issues relating to METIS AIT simulations

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

METIS WCU blackbody source has too restricted wavelength range

2 participants