Add instrument name in LFOA default.yaml

[teutoburg]

One of the example notebooks in ScopeSim started producing ValueError: !OBS.instrument was not found in rc.__currsys__ for the LFOA. This key is usually found in all other instrument packages. I vaguely remember fixing this, not sure if it was in a local branch on my other machine maybe...

[teutoburg]

Nevermind, the LFOA package seems to have more issues than this one keyword...

[teutoburg]

Also, it does actually run, the error messages are printed but the exception is caught somewhere...

[hugobuddel]

Nevermind, the LFOA package seems to have more issues than this one keyword...

Also, it does actually run, the error messages are printed but the exception is caught somewhere...

Been there, got the T-shirt!

My conclusion was that we should ensure that all the other instruments that now rely on write_header() have a FitsExtraKeywords effect so we can just remove that entire function.

Not that I got around to that either. But the exception is annoying.

[teutoburg]

My conclusion was that we should ensure that all the other instruments that now rely on write_header() have a FitsExtraKeywords effect so we can just remove that entire function.

Agree. Not sure if I get around to that anytime soon...