Move slit to MICADO.yaml; general spec mode#308
Draft
oczoske wants to merge 4 commits intodev_masterfrom
Draft
Conversation
oczoske
added
instrument definition
Contributor
|
I suggest adding sub_pixel:
flag: Trueto the While not strictly related to the rest of this PR, it seems like a useful default and doesn't appear to impact performance too badly, at least on my machine... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The MICADO slit selection is moved to
MICADO.yamlin the form of aSlitWheel:A new mode
SPECis introduced, which replaces all current spectroscopic modes. The old modesSPEC_15000x20etc. still exist and should work as before with default settings as indicated by their name.FITS keywords are not yet updated when the slit is changed.
Closes #88