Refactoring and formatting in tests#311
Merged
teutoburg merged 4 commits intodev_masterfrom Feb 6, 2026
Merged
Conversation
hugobuddel
approved these changes
Feb 6, 2026
Comment on lines
+73
to
+79
| pytest.param( | ||
| "open", "H", 2, 27.5, 0.3, | ||
| marks=pytest.mark.xfail( | ||
| reason="something changed in ScopeSim..." | ||
| ), | ||
| ), | ||
| ("open", "Ks", 2, 27.1, 0.3), |
Collaborator
There was a problem hiding this comment.
This is pretty ugly! But that's fine, because the uglyness is a good reminder we should fix something. And nice that this works at all.
Contributor
Author
There was a problem hiding this comment.
Yeah, that was done by black, although I already reduced it somewhat, it originally put every parameter on a separate line. That's one of the cases where black is perhaps a bit ... overenthusiastic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mostly MICADO. Get rid of some warnings. Remove xfail from passing tests.