Sqlite3 and LevelDB persistent cache plugins + usage from DataSource#197
Open
confluence wants to merge 44 commits intoAstroua:developfrom
Open
Sqlite3 and LevelDB persistent cache plugins + usage from DataSource#197confluence wants to merge 44 commits intoAstroua:developfrom
confluence wants to merge 44 commits intoAstroua:developfrom
Conversation
…getIntensityCache; added debugging
… the key doesn't exist
…g to call test on all cache plugins.
…rectory, not just the parent directory, to make it easier to specify a different location for a test database.
…be overridden by tests
… before plugin shutdown. If files are to be deleted, this should be done by whatever is calling the test executables.
Contributor
Author
|
I have changed the format of the config -- now the full path to the database file / directory is specified, not the parent directory. This makes it easier to override the location of the database from the unit tests. This is the new format: |
…asn't cleaned up after a previous failed test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes Sqlite3 and LevelDB implementations of the persistent cache API, as two separate plugins (cherry-picked and adapted from @pfederl's code).
It also adds calls to this API from the quantile-finding functions used in DataSource.
Each plugin needs a parent directory for the database file to be specified in the configuration file (
~/.cartavis/config.json). One of the plugins can also be explicitly disabled in the configuration so that the other plugin is used. E.g.:{
"disabledPlugins" : [
"PCacheSqlite3"
],
}