Fix tools.dataTools.VAF_pc_cc bug #20
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Thanks, Tao! I'll look into it soon |
Owner
|
@JoannaChang Do you remember this? Otherwise I'll have a look myself |
Collaborator
|
I think this was just about how the package didn’t properly load through the GitHub. It loaded fine on my computer so I ran the analyses through that. I can take a look when I get back next week.
…________________________________
From: Mostafa Safaie ***@***.***>
Sent: Monday, August 14, 2023 11:38:54 AM
To: AtMostafa/multi-animal-alignment ***@***.***>
Cc: Joanna Chang ***@***.***>; Mention ***@***.***>
Subject: Re: [AtMostafa/multi-animal-alignment] Fix tools.dataTools.VAF_pc_cc bug (PR #20)
@JoannaChang<https://github.com/JoannaChang> Do you remember this? Otherwise I'll have a look myself
—
Reply to this email directly, view it on GitHub<#20 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AIACCHMMRKZQFOWHXIMBE5DXVHW25ANCNFSM6AAAAAA3BRCROY>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Owner
|
great, let's discuss when you get back here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The definitions of D and E are different from the definitions mentioned in Gallego, NatComm, 2018. Directly computing outside the loop should not make difference to E but may change D. The amended code places the computation of D and E inside the loop and use the first h columns for computing. The attached file contains some screenshots about this issue and also the test results based on my data.
small bug.docx