Environments and Roles can be JSON as well as Ruby#133
Open
pikesley wants to merge 4 commits intoAtalanta:masterfrom
Open
Environments and Roles can be JSON as well as Ruby#133pikesley wants to merge 4 commits intoAtalanta:masterfrom
pikesley wants to merge 4 commits intoAtalanta:masterfrom
Conversation
lib/cucumber/chef/client.rb
Outdated
Collaborator
There was a problem hiding this comment.
Think you meant for that to be *.json?
Collaborator
|
Nice! Just see my one little comment there; looks like a little typo. |
Collaborator
Author
|
Fixed. It's been a long day (also I'm sometimes an idiot) ;) |
Collaborator
Author
|
Oh dammit. It fails if there are no JSON files present. I'll add some kind of checking around this. |
Collaborator
Author
|
OK, try that for size :) |
Collaborator
Author
|
I think this works now... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was attempting to use Etsy's rather nice knife-spork tool, but it blew up because it expects environments as JSON, not as Ruby, so I changed the env in question over to JSON and then my cuke-chef runs started failing spectacularly because it was only uploading the *.rb envs.
Hence this. And it's also valid for a role to be JSON, too, of course.