Skip to content

Feature: Configurable "No free progression" flags, 3 new esper locations#61

Open
kielbasiago wants to merge 31 commits intoAtmaTek:mainfrom
kielbasiago:force-item-reward-checks
Open

Feature: Configurable "No free progression" flags, 3 new esper locations#61
kielbasiago wants to merge 31 commits intoAtmaTek:mainfrom
kielbasiago:force-item-reward-checks

Conversation

@kielbasiago
Copy link

@kielbasiago kielbasiago commented Oct 20, 2022

This is currently very volatile with character gating, will add example flags to break it soon

Overview

Consolidated a lot of data around checks into one spot (checks.py)
Refactored a ton of code to allow for forcing any check to reward anything

Notable Files

  • checks.py is where check definitions are now kept
  • event/event.py where the overrides take place

Check Changes

  • Narshe weapon shop supports 2 esper choices now (will probably set this back to item but it's stable)
  • Lone wolf can offer an esper now i.e. "You'll never get this 'Bahamut'!"
  • There can now be a magicite at the top of Fanatics Tower
  • Kefka at narshe is a Character/Esper guaranteed now by default

Flags

  • --force-item-rewards id1,id2,etc. force an item reward on any number of checks in the game
  • --force-esper-rewards id1,id2,etc. force an esper reward on any checks in the game
  • --force-esper-item-rewards id1,id2,etc. force an esper or item reward on any checks in the game

Extra

I made a tool to allow selecting these ids https://tracker.kielbasiago.com/checks

@kielbasiago kielbasiago changed the title Configurable "No free progression" flag "--force-item-rewards", "--force-esper-rewards", "--force-esper-item-rewards" Configurable "No free progression" flags, 3 new esper locations Oct 20, 2022
@kielbasiago kielbasiago changed the title Configurable "No free progression" flags, 3 new esper locations Feature: Configurable "No free progression" flags, 3 new esper locations Oct 21, 2022
@kielbasiago kielbasiago marked this pull request as ready for review October 21, 2022 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant