Feature: Configurable "No free progression" flags, 3 new esper locations#61
Open
kielbasiago wants to merge 31 commits intoAtmaTek:mainfrom
Open
Feature: Configurable "No free progression" flags, 3 new esper locations#61kielbasiago wants to merge 31 commits intoAtmaTek:mainfrom
kielbasiago wants to merge 31 commits intoAtmaTek:mainfrom
Conversation
- EGGERS JUMP! Big shoutout to AST! 😊
feat: narshe battle now char/esper only chore: add beta-specific var to checks.py
Fix: Narshe weapon shop #2 can now only be item by default Feature: song_utils file for getting character themes
Chore: rename nfce-classic => nfce Chore: rename nfc => nfcegp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is currently very volatile with character gating, will add example flags to break it soon
Overview
Consolidated a lot of data around checks into one spot (checks.py)
Refactored a ton of code to allow for forcing any check to reward anything
Notable Files
checks.pyis where check definitions are now keptevent/event.pywhere the overrides take placeCheck Changes
Flags
--force-item-rewards id1,id2,etc.force an item reward on any number of checks in the game--force-esper-rewards id1,id2,etc.force an esper reward on any checks in the game--force-esper-item-rewards id1,id2,etc.force an esper or item reward on any checks in the gameExtra
I made a tool to allow selecting these ids https://tracker.kielbasiago.com/checks