feat: add signature verification to node response#105
Open
jorgeantonio21 wants to merge 12 commits intomainfrom
Open
feat: add signature verification to node response#105jorgeantonio21 wants to merge 12 commits intomainfrom
jorgeantonio21 wants to merge 12 commits intomainfrom
Conversation
maschad
reviewed
Feb 10, 2025
jorgeantonio21
commented
Feb 10, 2025
| } else if let Some(usage) = chunk.get(USAGE) { | ||
| self.status = StreamStatus::Completed; | ||
| let _ = { | ||
| let guard = self.sui.blocking_read(); |
Contributor
Author
There was a problem hiding this comment.
How safe is it to have a blocking_read in an async stream ?
Another possibility is poll::pending and add logic to the poll next method to handle when a signature is ready, but that's a bit too much of hassle.
Member
There was a problem hiding this comment.
That's a good point, we actually try caching the keystore when creating the Streamer to avoid locking during stream processing, wdyt?
Contributor
Author
There was a problem hiding this comment.
I think it makes sense, but it is a bit of a pain
Member
There was a problem hiding this comment.
You're right, we might introduce unnecessary complexity here, let's revisit this after profiling
jorgeantonio21
commented
Feb 11, 2025
maschad
reviewed
Feb 11, 2025
maschad
reviewed
Feb 12, 2025
.github/workflows/ci.yml
Outdated
| - name: cargo format | ||
| run: cargo fmt --all -- --check | ||
|
|
||
| toml-format: |
Member
There was a problem hiding this comment.
Added some formatting for our .toml files
maschad
force-pushed
the
ja-add-signature-verification-to-node-response
branch
from
ba43916 to
b7369fb
Compare
jorgeantonio21
force-pushed
the
develop
branch
2 times, most recently
from
075ca00 to
ba3ac8e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.