Open
Conversation
* chore(deps): bump atoma-utils from `d59ea1f` to `dfe0830` Bumps [atoma-utils](https://github.com/atoma-network/atoma-node) from `d59ea1f` to `dfe0830`. - [Release notes](https://github.com/atoma-network/atoma-node/releases) - [Commits](AtomaAI/atoma-node@d59ea1f...dfe0830) --- updated-dependencies: - dependency-name: atoma-utils dependency-version: dfe0830ecffc5429b4c131bc88b18fb8016cd5b9 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> * chore(deps): bump atoma-p2p from `d59ea1f` to `dfe0830` Bumps [atoma-p2p](https://github.com/atoma-network/atoma-node) from `d59ea1f` to `dfe0830`. - [Release notes](https://github.com/atoma-network/atoma-node/releases) - [Commits](AtomaAI/atoma-node@d59ea1f...dfe0830) --- updated-dependencies: - dependency-name: atoma-p2p dependency-version: dfe0830ecffc5429b4c131bc88b18fb8016cd5b9 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> * chore(deps): bump atoma-sui from `d59ea1f` to `dfe0830` Bumps [atoma-sui](https://github.com/atoma-network/atoma-node) from `d59ea1f` to `dfe0830`. - [Release notes](https://github.com/atoma-network/atoma-node/releases) - [Commits](AtomaAI/atoma-node@d59ea1f...dfe0830) --- updated-dependencies: - dependency-name: atoma-sui dependency-version: dfe0830ecffc5429b4c131bc88b18fb8016cd5b9 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> * ppcie verifier logic * add tables for fiat (#442) * fix: ensure 400 is returned on cancelled streams * chore: removed unnecessary 400 response * chore: remove unnecessary comment and clone * feat: add metrics to track latency from proxy to node (#444) * feat: add metrics to track latency from proxy to node * fix: move network ticker to seperate thread * chore: added docs + removed unnecessary port * fix: remove unnecessary prepend * fix: add model names to stream cancellations (#447) * handle PR comments --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Martin Stefcek <35243812+Cifko@users.noreply.github.com> Co-authored-by: Chad Nehemiah <chad.nehemiah94@gmail.com>
* fix: update fiat * million
* feat: use fiat when available * address comments
maschad
force-pushed
the
mc/kubernetes-setup
branch
from
a7563d1 to
d9b6dbc
Compare
* feat: split tokens into input/output * fix clippy * fix openapi.yml * address comments --------- Co-authored-by: Chad Nehemiah <chad.nehemiah94@gmail.com>
maschad
force-pushed
the
mc/kubernetes-setup
branch
2 times, most recently
from
9391781 to
bc124fb
Compare
* squash commits and sync with develop * update cargo lock * resolve failing tests * resolve failing tests * resolve failing tests
maschad
force-pushed
the
mc/kubernetes-setup
branch
from
bc124fb to
55d9519
Compare
* fix: correctly track 400 errors * fix: update to correctly use status code * fix: track errors more granularly * chore: remove unnecessary clones * chore: some more clippy clean up
* ci: use stable toolchain * chore: address clippy issues * chore: fix type
Cifko
reviewed
Jun 12, 2025
Collaborator
Cifko
left a comment
Cifko
left a comment
There was a problem hiding this comment.
Is there a way to test this before we use it?
There was a problem hiding this comment.
Pull Request Overview
This PR integrates Kubernetes support for the atoma-proxy project by introducing Helm charts, environment-specific values files, and necessary Kubernetes manifests for components such as MetalLB and OpenTelemetry. Key changes include new infrastructure YAMLs for MetalLB, updated Helm configuration and templates for atoma-proxy, and several helper shell scripts to manage cluster setup, RBAC, addons, and deployments.
Reviewed Changes
Copilot reviewed 22 out of 22 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| helm/infrastructure/metallb-install.yaml | Adds MetalLB namespace and deployments/daemonsets for controller and speaker |
| helm/infrastructure/metallb-config.yaml | Introduces IPAddressPool and L2Advertisement resources for MetalLB |
| helm/atoma-proxy/values*.yaml | Provides environment-specific configurations for dev, prod, and global settings |
| helm/atoma-proxy/templates/* | Adds and updates Kubernetes manifests (ConfigMaps, Deployments, Services, Ingress, etc.) |
| helm/atoma-proxy/scripts/* | Introduces multiple scripts to simplify cluster setup, RBAC fixes, addon installation, and deployment |
| namespace: "atoma" | ||
| loki: | ||
| endpoint: http://loki:3100/loki/api/v1/push | ||
| otlp/tempo: |
There was a problem hiding this comment.
Consider quoting the key 'otlp/tempo' (e.g., "otlp/tempo") to avoid potential YAML parsing issues with the slash character.
Suggested change
| otlp/tempo: | |
| "otlp/tempo": |
| {{- else if eq .service "credentials" }} | ||
| name: credentials | ||
| {{- else if eq .service "prover" }} | ||
| number: 8080 |
There was a problem hiding this comment.
Consider using a values reference for the port instead of hardcoding 8080 for the 'prover' service to maintain consistency and configurability across environments.
Suggested change
| number: 8080 | |
| number: {{ $.Values.atomaProxy.proverPort }} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This integrates kubernetes into our
proxysetup, most of the relevant details are in theREADME.md