Skip to content

fix(server): handle Express 5 req.params type union #729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
itsmylife44 wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −6
Open

fix(server): handle Express 5 req.params type union #729

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/server/src/routes/sessions/routes/archive.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import { getErrorMessage, logError } from '../common.js';
export function createArchiveHandler(agentService: AgentService) {
return async (req: Request, res: Response): Promise<void> => {
try {
const { sessionId } = req.params;
const sessionId = req.params.sessionId as string;
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Using a type assertion with as string bypasses TypeScript's type safety and can hide runtime errors if req.params.sessionId is not a string (e.g., undefined or string[]). A runtime check is a more robust approach. This ensures the input is validated and invalid requests are handled gracefully with a 400 Bad Request response.

      const sessionId = req.params.sessionId;
      if (typeof sessionId !== 'string') {
        res.status(400).json({ success: false, error: 'Invalid sessionId parameter' });
        return;
      }

const success = await agentService.archiveSession(sessionId);

if (!success) {
Expand Down
2 changes: 1 addition & 1 deletion apps/server/src/routes/sessions/routes/delete.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import { getErrorMessage, logError } from '../common.js';
export function createDeleteHandler(agentService: AgentService) {
return async (req: Request, res: Response): Promise<void> => {
try {
const { sessionId } = req.params;
const sessionId = req.params.sessionId as string;
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Using a type assertion with as string bypasses TypeScript's type safety and can hide runtime errors if req.params.sessionId is not a string (e.g., undefined or string[]). A runtime check is a more robust approach. This ensures the input is validated and invalid requests are handled gracefully with a 400 Bad Request response.

      const sessionId = req.params.sessionId;
      if (typeof sessionId !== 'string') {
        res.status(400).json({ success: false, error: 'Invalid sessionId parameter' });
        return;
      }

const success = await agentService.deleteSession(sessionId);

if (!success) {
Expand Down
2 changes: 1 addition & 1 deletion apps/server/src/routes/sessions/routes/unarchive.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import { getErrorMessage, logError } from '../common.js';
export function createUnarchiveHandler(agentService: AgentService) {
return async (req: Request, res: Response): Promise<void> => {
try {
const { sessionId } = req.params;
const sessionId = req.params.sessionId as string;
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Using a type assertion with as string bypasses TypeScript's type safety and can hide runtime errors if req.params.sessionId is not a string (e.g., undefined or string[]). A runtime check is a more robust approach. This ensures the input is validated and invalid requests are handled gracefully with a 400 Bad Request response.

      const sessionId = req.params.sessionId;
      if (typeof sessionId !== 'string') {
        res.status(400).json({ success: false, error: 'Invalid sessionId parameter' });
        return;
      }

const success = await agentService.unarchiveSession(sessionId);

if (!success) {
Expand Down
2 changes: 1 addition & 1 deletion apps/server/src/routes/sessions/routes/update.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import { getErrorMessage, logError } from '../common.js';
export function createUpdateHandler(agentService: AgentService) {
return async (req: Request, res: Response): Promise<void> => {
try {
const { sessionId } = req.params;
const sessionId = req.params.sessionId as string;
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Using a type assertion with as string bypasses TypeScript's type safety and can hide runtime errors if req.params.sessionId is not a string (e.g., undefined or string[]). A runtime check is a more robust approach. This ensures the input is validated and invalid requests are handled gracefully with a 400 Bad Request response.

      const sessionId = req.params.sessionId;
      if (typeof sessionId !== 'string') {
        res.status(400).json({ success: false, error: 'Invalid sessionId parameter' });
        return;
      }

const { name, tags, model } = req.body as {
name?: string;
tags?: string[];
Expand Down
2 changes: 1 addition & 1 deletion apps/server/src/routes/terminal/routes/session-delete.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import { getTerminalService } from '../../../services/terminal-service.js';
export function createSessionDeleteHandler() {
return (req: Request, res: Response): void => {
const terminalService = getTerminalService();
const { id } = req.params;
const id = req.params.id as string;
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Using a type assertion with as string bypasses TypeScript's type safety and can hide runtime errors if req.params.id is not a string (e.g., undefined or string[]). A runtime check is a more robust approach. This ensures the input is validated and invalid requests are handled gracefully with a 400 Bad Request response.

    const id = req.params.id;
    if (typeof id !== 'string') {
      res.status(400).json({ success: false, error: 'Invalid id parameter' });
      return;
    }

const killed = terminalService.killSession(id);

if (!killed) {
Expand Down
2 changes: 1 addition & 1 deletion apps/server/src/routes/terminal/routes/session-resize.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import { getTerminalService } from '../../../services/terminal-service.js';
export function createSessionResizeHandler() {
return (req: Request, res: Response): void => {
const terminalService = getTerminalService();
const { id } = req.params;
const id = req.params.id as string;
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Using a type assertion with as string bypasses TypeScript's type safety and can hide runtime errors if req.params.id is not a string (e.g., undefined or string[]). A runtime check is a more robust approach. This ensures the input is validated and invalid requests are handled gracefully with a 400 Bad Request response.

    const id = req.params.id;
    if (typeof id !== 'string') {
      res.status(400).json({ success: false, error: 'Invalid id parameter' });
      return;
    }

const { cols, rows } = req.body;

if (!cols || !rows) {
Expand Down