Skip to content

remove model as property since it is implemented as alias #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
younesStrittmatter wants to merge 3 commits into
base: main
Choose a base branch
from
Open

remove model as property since it is implemented as alias #92

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
35fa3a3
remove model as property since it is implemented as alias
younesStrittmatter Aug 10, 2024
e7d0a6c
chore: make pre-commit run
younesStrittmatter Aug 10, 2024
06e7d70
fix: add back in property (needed), but setter is not needed
younesStrittmatter Aug 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions src/autora/state.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1535,15 +1535,11 @@ def y(self) -> pd.DataFrame:

@property
def model(self):
if len(self.models) == 0:
"""Alias for the last model in the `models`."""
try:
return self.models[-1]
except IndexError:
return None
# The property to access the backing field
return self.models[-1]

@model.setter
def model(self, value):
# Control the setting behavior
self.models.append(value)


X = TypeVar("X")
Expand Down