Translate self-loops in discovered bpmn model #165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…loops Split Miner discovers BPMN models where, when an activity has a self-loop, it denotes it through an attribute in the '<task>' element, rather than an explicit XOR gateway structure. The post-processing stage surrounds all tasks with such attribute with an XOR-split/XOR-join structure that models a self-loop of that activity.
Split Miner 1 (SM1) uses all events written in the XES file to form the sequence of activities corresponding to each case. If running SM1 with a XES event log storing both lifecycles (Start and End), SM1 interprets it as two events of the same activity, and thus discovers a self-loop for all of them. Simod now generates two XES, one with two events per activity instance (start and end), and another one with only one (end). Still an issue, not SM1 or SM2 order the events of a trace. In the case of SM2, they are written always in pairs (A_s-A_e then B_s-B_e), when two activities are in parallel, SM2 reads the written order (A_s-A_e-B_s-B_e) and doesn't interpret real chronological order (A_s-B_s-A_e-B_e). TODO: either change XES writer to write events individually in order, or change SM2 to sort before using.
|
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #165 +/- ##
==========================================
+ Coverage 86.99% 87.50% +0.50%
==========================================
Files 58 57 -1
Lines 2715 2793 +78
==========================================
+ Hits 2362 2444 +82
+ Misses 353 349 -4 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Split Miner (both versions) discovers a BPMN model with tasks with self-loops, it describes it through a tag within the task. Added an automated translation of the model to explicitly model such self-loops with an XOR-split/XOR-join structure.