Skip to content

Conversation

@david-chapela
Copy link
Collaborator

Fixed two bugs related to control-flow discovery:

  1. Do not escape paths with double quotes in non-Windows systems to avoid errors.
  2. Discovery of final BPS model now uses the correct XES log transformation when SplitMiner1 is the discovery algorithm (previously, it created a XES with both start and end events, and SplitMiner interpreted this as self-loops in all activities).

@david-chapela david-chapela self-assigned this May 27, 2025
@sonarqubecloud
Copy link

@david-chapela david-chapela linked an issue May 27, 2025 that may be closed by this pull request
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 95.12195% with 2 lines in your changes missing coverage. Please review.

Project coverage is 87.46%. Comparing base (02afc5f) to head (dc8fc8f).

Files with missing lines Patch % Lines
src/simod/control_flow/discovery.py 66.66% 1 Missing ⚠️
src/simod/simod.py 75.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #171      +/-   ##
==========================================
+ Coverage   87.39%   87.46%   +0.06%     
==========================================
  Files          57       57              
  Lines        2793     2831      +38     
==========================================
+ Hits         2441     2476      +35     
- Misses        352      355       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@david-chapela david-chapela merged commit 56cd99f into master May 27, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error When Running Control Flow Discovery

3 participants