Improve efficiency of getRendition#1
Open
HaroldPutman wants to merge 2 commits intoAvionosLLC:developfrom
Open
Improve efficiency of getRendition#1HaroldPutman wants to merge 2 commits intoAvionosLLC:developfrom
HaroldPutman wants to merge 2 commits intoAvionosLLC:developfrom
Conversation
`getRenditionForBaseName()` was being called whether or not getRenditionForName found the rendition. Using orElseGet will only call it if the rendition was not found.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you find the rendition by the requested name, there is no reason to try to find it by the basename also. But,
orElse()on anOptional will evaluate its parameter every time. Switching to
orElseGetand a Suppler lambda expression prevents that.