Skip to content

Fix #1236: Error in server log when trying to place an MI pipe out of world bounds #1237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Swedz wants to merge 1 commit into
base: 1.21.x
Choose a base branch
from
Open

Fix #1236: Error in server log when trying to place an MI pipe out of world bounds #1237

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/main/java/aztech/modern_industrialization/pipes/impl/PipeItem.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,10 @@
import aztech.modern_industrialization.pipes.electricity.ElectricityNetworkData;
import aztech.modern_industrialization.pipes.fluid.FluidNetworkData;
import aztech.modern_industrialization.pipes.item.ItemNetworkData;
import net.minecraft.ChatFormatting;
import net.minecraft.core.BlockPos;
import net.minecraft.network.chat.Component;
import net.minecraft.server.level.ServerPlayer;
import net.minecraft.sounds.SoundSource;
import net.minecraft.world.InteractionResult;
import net.minecraft.world.entity.player.Player;
Expand Down Expand Up @@ -154,6 +157,13 @@ private boolean tryPlaceAt(UseOnContext context, BlockPos pos) {
}

private static boolean canPlace(UseOnContext ctx, BlockPos pos) {
if(!ctx.getLevel().isInWorldBounds(pos)) {
int worldHeightLimit = ctx.getLevel().getMaxBuildHeight();
if(ctx.getPlayer() instanceof ServerPlayer player && pos.getY() >= worldHeightLimit) {
player.sendSystemMessage(Component.translatable("build.tooHigh", worldHeightLimit - 1).withStyle(ChatFormatting.RED), true);
}
return false;
}
BlockState state = MIPipes.BLOCK_PIPE.get().defaultBlockState();
CollisionContext shapeContext = ctx.getPlayer() == null ? CollisionContext.empty() : CollisionContext.of(ctx.getPlayer());
return ctx.getLevel().getBlockState(pos).canBeReplaced(new BlockPlaceContext(ctx)) && state.canSurvive(ctx.getLevel(), pos)
Expand Down
Loading