{CI} Suppress false positives in Credential Scanner #32669
Merged
+12
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
necusjz
requested review from
bebound,
calvinhzy,
jiasli,
kairu-ms and
wangzelin007
as code owners
️✔️AzureCLI-FullTest
|
|
Hi @necusjz, |
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
requested review from
Pan-Qi,
jsntcy and
yonzhan
Contributor
There was a problem hiding this comment.
Pull request overview
This PR suppresses two false positive credential scanner alerts that were blocking CI builds. The credential scanner incorrectly flagged benign code patterns as potential security issues.
Changes:
- Added suppression for PostgreSQL module's
flexible_server_custom_postgres.pywhich uses placeholder strings like'<user>'and'<password>'in output messages - Added suppression for Network module's test file
test_network_commands.pywhich uses a hardcoded test password for certificate generation in tests
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
wangzelin007
approved these changes
Jan 19, 2026
bebound
approved these changes
Jan 19, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
Description
from https://dev.azure.com/azclitools/public/_build/results?buildId=291659&view=logs&jobId=9a50307c-53e6-51fa-ddad-d8767a4a0ece&j=9a50307c-53e6-51fa-ddad-d8767a4a0ece&t=51a28232-c495-58b8-0a15-8a556d230675:
Both
azure-cli/src/azure-cli/azure/cli/command_modules/postgresql/flexible_server_custom_postgres.py
Line 211 in aeee555
and
azure-cli/src/azure-cli/azure/cli/command_modules/network/tests/latest/test_network_commands.py
Line 6256 in 47cfdec
don't have any secret. They're false positives.
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.