Skip to content

Conversation

@mainred
Copy link
Member

@mainred mainred commented Jan 20, 2026

Related command

Description

urllib 2.6.0 removed HTTPResponse.getheader and blocks many libraries including kubernetes-client, which is used in several cli extensions including aks-agent, container-app and k8s-extension. urllib3 team has restored this function since 2.6.1.

urllib3/urllib3#3731

Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change
[Component Name 2] az command b: Add some customer-facing feature


This checklist is used to make sure that common guidelines for a pull request are followed.

Copilot AI review requested due to automatic review settings January 20, 2026 04:57
@azure-client-tools-bot-prd
Copy link

Validation for Azure CLI Full Test Starting...

Thanks for your contribution!

@azure-client-tools-bot-prd
Copy link

Hi @mainred,
Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

@yonzhan
Copy link
Collaborator

yonzhan commented Jan 20, 2026

Thank you for your contribution! We will review the pull request and get back to you soon.

@azure-client-tools-bot-prd
Copy link

Validation for Breaking Change Starting...

Thanks for your contribution!

@github-actions
Copy link

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request updates the urllib3 dependency from version 2.6.0 to 2.6.3 to address an incompatibility issue where urllib3 2.6.0 removed the HTTPResponse.getheader method, which broke several CLI extensions including aks-agent, container-app, and k8s-extension. Version 2.6.1+ restores this functionality.

Changes:

  • Updated urllib3 from 2.6.0 to 2.6.3 in Windows and Linux requirements files

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/azure-cli/requirements.py3.windows.txt Updated urllib3 dependency to version 2.6.3 for Windows platform
src/azure-cli/requirements.py3.Linux.txt Updated urllib3 dependency to version 2.6.3 for Linux platform

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mainred mainred closed this Jan 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants