Skip to content

Conversation

@Siecje
Copy link

@Siecje Siecje commented Sep 3, 2024

Checklist

  • I have read the contribution guidelines.
  • I added or modified the existing tests to cover the change (we do not allow our test coverage to go down).
  • If this is a modification that impacts the behavior of a public API
    • I edited the corresponding document in the devdoc folder and added or modified requirements.

Reference/Link to the issue solved with this PR (if any)

#1192

Description of the problem

this can be None if the object has already been garbage collected.

Description of the solution

Check if this is None and log as in on_disconnect.

@cartertinney
Copy link
Member

Can't merge external contributions right now due to CI policy - I'll try and pull this in as a separate PR

@Siecje
Copy link
Author

Siecje commented Jan 17, 2026

Cherry pick the commit into another PR or just make the changes yourself.

@cartertinney cartertinney added the add-as-internal-pr We cannot currently accept external PRs due to CI label Jan 17, 2026
@cartertinney
Copy link
Member

cartertinney commented Jan 17, 2026

@Siecje Yeah, we're just bringing some repository infrastructure back online, so once that's sorted I'll look at opening my own PR on this.

However, since you submitted it, can you explain more about the scenario where this happens? My understanding had been that this wasn't something that could happen, which is why it wasn't handled (unlike in on_disconnect where it was handled). Do you have a scenario that can reproduce the issue?

I realize it's been a year, so you may not have that info on hand, but if you have anything to go off of, it'd be appreciated.

@Siecje
Copy link
Author

Siecje commented Jan 17, 2026

Have you seen this? #1192

I don't have anymore context. I do not work on that project anymore.

@cartertinney
Copy link
Member

Great, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

add-as-internal-pr We cannot currently accept external PRs due to CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants