[Keyvault] add breaking change attribute for GetAzureKeyVaultSecret and GetAzureKeyVaultKey #29051
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
DanielMicrosoft
added
KeyVault
Breaking Change Preannounce
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds breaking change notification attributes to two Key Vault cmdlets (Get-AzKeyVaultSecret and Get-AzKeyVaultKey) to inform users that certificate-backed secrets and keys will no longer be returned when listing these resources in a future release (version 16.0.0). This change prepares users for the breaking changes planned in PR #29015.
Changes:
- Added
GenericBreakingChangeWithVersionattribute toGetAzureKeyVaultSecretclass - Added
GenericBreakingChangeWithVersionattribute toGetAzureKeyVaultKeyclass - Added necessary namespace import (
Microsoft.WindowsAzure.Commands.Common.CustomAttributes) to both files
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/KeyVault/KeyVault/Commands/Secret/GetAzureKeyVaultSecret.cs | Added breaking change attribute and namespace import to notify users that certificate-backed secrets will no longer be returned when listing secrets |
| src/KeyVault/KeyVault/Commands/Key/GetAzureKeyVaultKey.cs | Added breaking change attribute and namespace import to notify users that certificate-backed keys will no longer be returned when listing keys |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Breaking notification attributes added for GetAzureKeyVaultSecret and GetAzureKeyVaultKey.
Changes will be implemented in #29015
And relates to #26217.
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.